[smokeping-users] Re: missing max for DS uptime? again

[Niko Tyni]

On Thu, Mar 16, 2006 at 04:20:41PM +0000, Fran Boon wrote:

> /var/www/smokeping/var/Web/Star.rrd: missing max for DS uptime?
 
> Browsing through the mail archives, I see that this has come up before:
> http://lists.ee.ethz.ch/smokeping-users/msg01473.html
> There is talk there of a fix in the next release...did this make it in?
> My Perl is 5.8.0-90.4

Hi,

it did make it in 2.0rc5, but the test for the buggy Perl version 5.8.0
was broken in 2.0.6. Tobi, what's the background for this change?

--- lib/Smokeping/RRDtools.pm	(revision 382)
+++ lib/Smokeping/RRDtools.pm	(revision 383)
@@ -104,7 +104,7 @@
 sub info2create {
 	my $file = shift;
 	my @create;
-    my $buggy_perl_version = 1 if $^V and $^V eq v5.8.0;
+        my $buggy_perl_version = 1 if $^V and $^V eq "v5.8.0";
 	my $info = RRDs::info($file);
 	my $error = RRDs::error;
 	die("RRDs::info $file: ERROR: $error") if $error;

The new code looks broken to me. See eg. 
http://www.unix.org.ua/orelly/perl/prog3/ch02_06.htm
section 2.6.7, "V-String Literals". 

The changelog mentions the fix is for Perl 5.8.7, but the old code seems
to work on at least 5.8.8. Is 5.8.7 broken wrt. v-strings?

Fran: reverting this patch should help for the time being.

HTH,
-- 
Niko

--
Unsubscribe mailto:smokeping-users-request at list.ee.ethz.ch?subject=unsubscribe
Help        mailto:smokeping-users-request at list.ee.ethz.ch?subject=help
Archive     http://lists.ee.ethz.ch/smokeping-users
WebAdmin    http://lists.ee.ethz.ch/lsg2.cgi