[smokeping-users] Smokeping 2.4.2 alert URL issue (minor)

Dez Cadena dez at otenet.gr
Fri Feb 19 14:14:34 CET 2010


Hi, I've just noticed that in 2.4.2 when an alert -that is triggered by 
a slave- is received, the URL is the body of the message gets messed up 
because the "[from slave]" part is appended to the URL without a space 
and if you click on it you'll get an error, e.g.:

Alert "core" was cleared for
http://mysite/cgi-bin/smokeping.cgi?target=somepath.somehost[from someslave]

something like the following would resolve the (minor) issue:


[x at y]# diff /usr/local/src/smokeping/smokeping-2.4.2/lib/Smokeping.pm  
/usr/local/smokeping/lib/Smokeping.pm
1809c1809
<                 $line .= "[from $slave]" if $slave;
---
 >                 $line .= " [from $slave]" if $slave;


Tobi, do you think it's worth patching?

cheers,

Dez

p.s: sorry if its been brought up before



More information about the smokeping-users mailing list