[smokeping-users] Smokeping 2.4.2 alert URL issue (minor)

[Tobias Oetiker]

Hi Dez,

sure ... I have fixed it in trunk. thanks
tobi

Today Dez Cadena wrote:

> Hi, I've just noticed that in 2.4.2 when an alert -that is triggered by
> a slave- is received, the URL is the body of the message gets messed up
> because the "[from slave]" part is appended to the URL without a space
> and if you click on it you'll get an error, e.g.:
>
> Alert "core" was cleared for
> http://mysite/cgi-bin/smokeping.cgi?target=somepath.somehost[from someslave]
>
> something like the following would resolve the (minor) issue:
>
>
> [x at y]# diff /usr/local/src/smokeping/smokeping-2.4.2/lib/Smokeping.pm
> /usr/local/smokeping/lib/Smokeping.pm
> 1809c1809
> <                 $line .= "[from $slave]" if $slave;
> ---
>  >                 $line .= " [from $slave]" if $slave;
>
>
> Tobi, do you think it's worth patching?
>
> cheers,
>
> Dez
>
> p.s: sorry if its been brought up before
>
> _______________________________________________
> smokeping-users mailing list
> smokeping-users at lists.oetiker.ch
> https://lists.oetiker.ch/cgi-bin/listinfo/smokeping-users
>
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch tobi at oetiker.ch ++41 62 775 9902 / sb: -9900